guard for None content as response from target
#1574
Merged
+74
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
jmartin-tech
added
bug
jmartin-tech
force-pushed
the
fix/atkgen-guard-none-response
branch
from
1c09cc0 to
540a5da
Compare
validate all response access as a generator can `None` during attack iteration in various ways Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
jmartin-tech
force-pushed
the
fix/atkgen-guard-none-response
branch
from
540a5da to
9016aaf
Compare
jmartin-tech
commented
Jan 27, 2026
Comment on lines
+236
to
+239
| # if response_to_store is None it will be coerced to "" on iteration hence the extra check | ||
| if (response_to_store == last_response) or ( | ||
| len(last_response) == 0 and not response_to_store | ||
| ): |
Collaborator
Author
There was a problem hiding this comment.
This revision was pointed out by tests, current expectation is to giveup when the first response results in an empty result from the target.
…plicit bool flag; stop conversation if generator throws Nones / other unprocessable emerges
Collaborator
|
see jmartin-tech#1 |
Collaborator
|
"the go-to-market" from me too |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases models will respond with
Noneornullresponse a prompt hits and edge case.Since atkgen is looking for edges, extra care is needed to ensure this is accounted for.
In one particular case it has been determined that reasoning models may consume their entire token budget and return
Nonefor message content for various inputs this probe can generate.Verification
List the steps needed to make sure this thing works
openai/gpt-oss-120bgarak -t nim -n openai/gpt-oss-120b --generator_options '{"nim":{"uri":"https://example.com/v1/"}}' -p atkgen.Tox