Open
Conversation
There are a lots of functions that are local only. It means they don't need a prototype and they can be static. This commit move some of that functions and fix some compilation warnings regarding to -Wmissing-prototype flag. Signed-off-by: Julio Faracco <[email protected]>
There are some global definitition of MAX and MIN at linux/minmax.h. To avoid compilation issues, it is better to put them into guards. Signed-off-by: Julio Faracco <[email protected]>
The compiler is complaining about several prototypes. It is caused by the missing inclusion of the nvfs-rdma.h. Signed-off-by: Julio Faracco <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a lots of fixes related to warnings reported by the compiler (it can have even more).
It changes:
staticto avoid the requirement to define a prototype (they are all used locally by its own X file).MAX()andMIN()definition.nvfs-rdma.h.