Skip to content

Conversation

@shivakunv
Copy link
Contributor

@shivakunv shivakunv commented Nov 14, 2025

Currently, the GPU Operator image configured in the bundle is ghcr.io/nvidia/gpu-operator:main-latest (see here). This can be problematic for two reasons. First, it is difficult to deduce which commit SHA the operator image / OLM bundle was built from. Therefore, it is difficult to infer which commit SHA introduced a test failure. Second, the gpu-operator deployment runs with imagePullPolicy=IfNotPresent by default. This means if the gpu-operator image (with the main-latest) tag is already cached on the node, the latest image may not be pulled / tested. To address these shortcomings, we should generate an OLM bundle that is using SHA-tagged images of gpu-operator.
We should update the GitHub Actions job that builds + pushes an OLM bundle image as follows:

  1. Before building the bundle image, it should update all gpu-operator image tags in the CSV file to refer to the commit SHA. E.g. ghcr.io/nvidia/gpu-operator:commit-short-sha
  2. When pushing the OLM bundle image, we should push two tags – one tag will be main-latest and the other will be commit-short-sha

@shivakunv shivakunv self-assigned this Nov 14, 2025
@coveralls
Copy link

coveralls commented Nov 14, 2025

Coverage Status

coverage: 23.552%. remained the same
when pulling 9811ba4 on bundlecommitsha
into 4011723 on main.

@shivakunv shivakunv force-pushed the bundlecommitsha branch 2 times, most recently from 2411206 to 076614c Compare November 18, 2025 04:06
@shivakunv
Copy link
Contributor Author

@shivakunv shivakunv marked this pull request as ready for review November 18, 2025 04:14
@shivakunv shivakunv changed the title Tag git commit sha with bundle image Tag bundle image with current commit sha Nov 18, 2025
@shivakunv shivakunv force-pushed the bundlecommitsha branch 2 times, most recently from 60f07a4 to 3368b51 Compare November 24, 2025 18:27
@shivakunv
Copy link
Contributor Author

PTAL @cdesiniotis @tariq1890

@shivakunv shivakunv force-pushed the bundlecommitsha branch 2 times, most recently from 6400104 to a2d3451 Compare December 9, 2025 10:44
@shivakunv
Copy link
Contributor Author

@rajathagasthya : PTAL

@shivakunv
Copy link
Contributor Author

shivakunv commented Dec 9, 2025

@shivakunv
Copy link
Contributor Author

@shivakunv
Copy link
Contributor Author

Thanks @rajathagasthya
PTAL @tariq1890 @cdesiniotis

@shivakunv shivakunv force-pushed the bundlecommitsha branch 2 times, most recently from 839de60 to 9800cef Compare December 16, 2025 05:00
Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
@shivakunv shivakunv merged commit 9ffbac0 into main Dec 19, 2025
28 of 29 checks passed
@shivakunv shivakunv deleted the bundlecommitsha branch December 19, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants