-
Notifications
You must be signed in to change notification settings - Fork 434
Tag bundle image with current commit sha #1898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2411206 to
076614c
Compare
Contributor
Author
|
passed pipeline: https://github.com/NVIDIA/gpu-operator/actions/runs/19452460548 |
60f07a4 to
3368b51
Compare
Contributor
Author
|
PTAL @cdesiniotis @tariq1890 |
tariq1890
reviewed
Dec 3, 2025
ac8f2c2 to
9e0e52a
Compare
rajathagasthya
requested changes
Dec 9, 2025
6400104 to
a2d3451
Compare
Contributor
Author
|
@rajathagasthya : PTAL |
a2d3451 to
4186ff9
Compare
Contributor
Author
|
passed pipeline : https://github.com/NVIDIA/gpu-operator/actions/runs/20061702250 |
d9a590d to
2b77660
Compare
rajathagasthya
previously requested changes
Dec 11, 2025
2b77660 to
793b7d5
Compare
b9a22d8 to
cb0d983
Compare
Contributor
Author
cb0d983 to
6a135cf
Compare
rajathagasthya
approved these changes
Dec 15, 2025
Contributor
Author
|
Thanks @rajathagasthya |
cdesiniotis
reviewed
Dec 15, 2025
839de60 to
9800cef
Compare
rajathagasthya
approved these changes
Dec 16, 2025
rajathagasthya
previously requested changes
Dec 16, 2025
9800cef to
beb124e
Compare
beb124e to
166e4e3
Compare
rajathagasthya
approved these changes
Dec 16, 2025
tariq1890
reviewed
Dec 17, 2025
Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
166e4e3 to
9811ba4
Compare
tariq1890
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the GPU Operator image configured in the bundle is ghcr.io/nvidia/gpu-operator:main-latest (see here). This can be problematic for two reasons. First, it is difficult to deduce which commit SHA the operator image / OLM bundle was built from. Therefore, it is difficult to infer which commit SHA introduced a test failure. Second, the gpu-operator deployment runs with
imagePullPolicy=IfNotPresentby default. This means if the gpu-operator image (with the main-latest) tag is already cached on the node, the latest image may not be pulled / tested. To address these shortcomings, we should generate an OLM bundle that is using SHA-tagged images of gpu-operator.We should update the GitHub Actions job that builds + pushes an OLM bundle image as follows: