Skip to content

Conversation

@shivakunv
Copy link
Contributor

@shivakunv shivakunv commented Dec 19, 2025

https://github.com/NVIDIA/gpu-operator/actions/runs/20362800010/job/58514956441 : The CI pipeline failed after merging to main: #1898 from NVIDIA/bundlecommitsha : Tag git commit sha with bundle image

https://github.com/NVIDIA/gpu-operator/actions/runs/20364821808/job/58518239572 : Pipeline was reproduced

https://github.com/NVIDIA/gpu-operator/actions/runs/20364821808/job/58518239572: Pipeline passed with the new change

Please refer to the links below for details on the bug and compatibility issues with sed:

  1. https://www.baeldung.com/linux/sed-error-no-such-file-or-directory
  2. https://stackoverflow.com/questions/67086574/no-such-file-or-directory-when-using-sed-in-combination-with-find

sed -i '' -e 's|ghcr.io/nvidia/gpu-operator:[^ "]*|ghcr.io/nvidia/gpu-operator:${{ env.COMMIT_SHORT_SHA }}|g' bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml : This command works only on Mac OS.

sed -i'' -e 's|ghcr.io/nvidia/gpu-operator:[^ "]*|ghcr.io/nvidia/gpu-operator:${{ env.COMMIT_SHORT_SHA }}|g' bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml : This works for both MacOS and Linux, creates a backup file with a -e extension on macOS

sed -i -e 's|ghcr.io/nvidia/gpu-operator:[^ "]*|ghcr.io/nvidia/gpu-operator:${{ env.COMMIT_SHORT_SHA }}|g' bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml : This works only on Linux, not Mac OS.

@shivakunv shivakunv self-assigned this Dec 19, 2025
@shivakunv shivakunv force-pushed the commitsha branch 2 times, most recently from 05cfee2 to f2c20dd Compare December 19, 2025 09:28
@shivakunv shivakunv changed the title Tag git commit sha with bundle image Fix: sed portability and compatibility issue for the bundle commitSha image Dec 19, 2025
@shivakunv shivakunv marked this pull request as ready for review December 19, 2025 09:33
@coveralls
Copy link

Coverage Status

coverage: 23.552%. remained the same
when pulling 9d84555 on commitsha
into 9ffbac0 on main.

@coveralls
Copy link

Coverage Status

coverage: 23.552%. remained the same
when pulling 76dfef9 on commitsha
into 9ffbac0 on main.

@coveralls
Copy link

coveralls commented Dec 19, 2025

Coverage Status

coverage: 23.552%. remained the same
when pulling a73f0f0 on commitsha
into 208ab8c on main.

Copy link
Contributor

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If additional file creation was an issue, we could have also used yq. For now, this also looks good to me.

@shivakunv
Copy link
Contributor Author

LGTM. If additional file creation was an issue, we could have also used yq. For now, this also looks good to me.

That won't be an issue since we have a Linux runner for CI/CD, so a local file won't be created. A local file will only be created if we use Mac-OS, such as during local testing.

@rajathagasthya
Copy link
Contributor

/ok-to-test a73f0f0

@tariq1890 tariq1890 enabled auto-merge December 19, 2025 18:07
@tariq1890 tariq1890 merged commit 581c9d6 into main Dec 19, 2025
17 checks passed
@tariq1890 tariq1890 deleted the commitsha branch December 19, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants