Skip to content

[release-25.10] use PATCH to update node labels instead of UPDATE #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

[release-25.10] use PATCH to update node labels instead of UPDATE #1874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion controllers/state_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,8 @@ func (n *ClusterPolicyController) labelGPUNodes() (bool, int, error) {
gpuNodesTotal := 0
for _, node := range list.Items {
node := node

nodeOriginal := node.DeepCopy()
// get node labels
labels := node.GetLabels()
if !clusterHasNFDLabels {
Expand Down Expand Up @@ -566,7 +568,7 @@ func (n *ClusterPolicyController) labelGPUNodes() (bool, int, error) {

// update node with the latest labels
if updateLabels {
err = n.client.Update(ctx, &node)
err = n.client.Patch(ctx, &node, client.MergeFrom(nodeOriginal))
if err != nil {
return false, 0, fmt.Errorf("unable to label node %s for the GPU Operator deployment, err %s",
node.Name, err.Error())
Expand Down