Conversation
f4de636 to
1bd23fe
Compare
|
I think previously @tariq1890 reviewed previous Pull request |
|
Thanks for the contribution @itspooya. Would you be able to rebase and resolve the merge conflicts? |
|
I was able to confirm this is working as expected. Below is how I verified. I added the below print statements to the top of Before df18cd2 was introduced, the output was below: After df18cd2 was introduced, the output became: And with the changes introduced in this PR (using the functionality from the Go standard library), the output is: This appears to be the expected behavior according to https://pkg.go.dev/runtime#hdr-Implementation_details-GOMAXPROCS. |
Signed-off-by: itspooya <[email protected]>
1bd23fe to
015a568
Compare
|
/ok to test 015a568 |
cdesiniotis
left a comment
There was a problem hiding this comment.
@itspooya thanks for the contribution.
Hi,
Previously I have created following pull request to fix an issue which was present on older golang versions
#1297
but golang v1.25 has added this feature and I think based on that, using a custom library is not needed anymore
https://go.dev/doc/go1.25#container-aware-gomaxprocs