fix(utils): close SSH client in GetKubeConfig#640
Merged
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom Feb 13, 2026
Merged
fix(utils): close SSH client in GetKubeConfig#640ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an SSH connection leak in GetKubeConfig (a utility used to fetch kubeconfig from a provisioned host) by ensuring the SSH client created by provisioner.New() is closed when the function returns.
Changes:
- Add a
deferto closep.Clientafter successfulprovisioner.New()inGetKubeConfig.
Pull Request Test Coverage Report for Build 21960949084Details
💛 - Coveralls |
provisioner.New() opens an SSH connection that was never closed, leaking a TCP socket and SSH multiplexer goroutines on every call. Audit finding NVIDIA#4 (HIGH). Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
199b559 to
26a335c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defer func() { _ = p.Client.Close() }()afterprovisioner.New()inpkg/utils/kubeconfig.goprovisioner.New()opens an SSH connection that was never closed, leaking a TCP socket and SSH multiplexer goroutines on every call toGetKubeConfigAudit Finding
GetKubeConfigTest plan
gofmt— no formatting issuesgolangci-lint run ./...— 0 issuesgo test -coverprofile=coverage.out ./pkg/...— all PASSgo build -o bin/holodeck cmd/cli/main.go— compilesgo mod tidy && go mod verify— no changes, all modules verified