fix(cleanup): replace signal goroutine with signal.NotifyContext#649
Merged
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom Feb 13, 2026
Merged
Conversation
The signal handler goroutine never exited after run() returned. signal.NotifyContext handles cleanup automatically and avoids the goroutine leak. Audit finding NVIDIA#28 (LOW). Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the holodeck cleanup CLI command to use signal.NotifyContext instead of a manual signal.Notify + goroutine pattern, eliminating a signal-handler goroutine that could outlive run() and leak.
Changes:
- Replace
context.WithCancel+signal.Notify+ goroutine withsignal.NotifyContext. - Ensure signal handling is properly stopped via the returned
stop()function (defer stop()).
Pull Request Test Coverage Report for Build 21961989439Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signal.NotifyContextto prevent goroutine leak afterrun()returnsgo func() { <-sigChan ... }) never exited when cleanup completed normallyAudit Finding
cmd/cli/cleanup/cleanup.goChanges
cmd/cli/cleanup/cleanup.go: Replacecontext.WithCancel+signal.Notify+ goroutine pattern withsignal.NotifyContextTest plan
gofmt— no formatting issuesgo build -o bin/holodeck cmd/cli/main.go— compilesgo test ./pkg/...— all tests pass