Skip to content

Conversation

@shivamerla
Copy link
Contributor

On coherent-memory systems, the possible modes are:

  • HMM - (Hardware Memory Management mode)
  • ATS - (Address Translation Service mode)
  • None - (Supported by the platform but currently inactive)

On others, its explicitly set to empty to indicate that it is not supported by the platform

@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 11, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shivamerla shivamerla marked this pull request as draft November 11, 2025 00:13
@shivamerla
Copy link
Contributor Author

shivamerla commented Nov 11, 2025

Is blocked by NVIDIA/go-nvlib#75

@shivamerla shivamerla moved this from Backlog to In Progress in Planning Board: k8s-dra-driver-gpu Nov 11, 2025
@shivamerla shivamerla modified the milestones: v25.3.2, v25.12.0 Nov 11, 2025
@klueska klueska added the feature issue/PR that proposes a new feature or functionality label Nov 26, 2025
On coherent-memory systems, the possible modes are:
  * HMM  - (Hardware Memory Management mode)
  * ATS  - (Address Translation Service mode)
  * None - (Supported by the platform but currently inactive)

On others, its explicitly set to empty to indicate that it is not supported by the platform

Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
@shivamerla shivamerla force-pushed the addressing_mode_attribute branch from 785ef7f to 4e59b95 Compare December 23, 2025 20:56
@shivamerla shivamerla marked this pull request as ready for review December 23, 2025 22:38
@shivamerla
Copy link
Contributor Author

@klueska go-nvlib is now updated to fetch the AddressingMode attribute. PTAL.

$ kubectl get resourceslice -o json | jq .items[1].spec.devices[0].attributes
{
  "addressingMode": {
    "string": "HMM"
  },
  "architecture": {
    "string": "Ampere"
  },
  "brand": {
    "string": "Nvidia"
  },
  "cudaComputeCapability": {
    "version": "8.0.0"
  },
  "cudaDriverVersion": {
    "version": "13.0.0"
  },
  "driverVersion": {
    "version": "580.95.5"
  },
  "pcieBusID": {
    "string": "0000:3b:00.0"
  },
  "productName": {
    "string": "NVIDIA A100-PCIE-40GB"
  },
  "resource.kubernetes.io/pcieRoot": {
    "string": "pci0000:3a"
  },
  "type": {
    "string": "gpu"
  },
  "uuid": {
    "string": "GPU-c021ba0a-76fd-9f12-7e4a-a8c3fce1c92d"
  }
}

Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
shivamerla and others added 2 commits January 21, 2026 08:57
Co-authored-by: Kevin Klues <klueska@gmail.com>
Signed-off-by: Shiva Krishna Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
@shivamerla shivamerla requested a review from klueska January 21, 2026 17:02
Copy link
Collaborator

@klueska klueska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you please squash into a single commit before merging.

@shivamerla shivamerla merged commit 1f62129 into NVIDIA:main Jan 21, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Planning Board: k8s-dra-driver-gpu Jan 21, 2026
@klueska
Copy link
Collaborator

klueska commented Jan 21, 2026

I still see 4 commits in this PR and on main I see a single commit without a merge commit. How did you merge this?

@shivamerla
Copy link
Contributor Author

I still see 4 commits in this PR and on main I see a single commit without a merge commit. How did you merge this?

With the Squash and Merge option which doesn't create the merge commit.

@klueska
Copy link
Collaborator

klueska commented Jan 21, 2026

In the future, please squash locally and repush so that all merges happen with a merge commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature issue/PR that proposes a new feature or functionality

Projects

Development

Successfully merging this pull request may close these issues.

2 participants