-
Notifications
You must be signed in to change notification settings - Fork 113
Add the memory addressing mode as an attribute for each device #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is blocked by NVIDIA/go-nvlib#75 |
On coherent-memory systems, the possible modes are: * HMM - (Hardware Memory Management mode) * ATS - (Address Translation Service mode) * None - (Supported by the platform but currently inactive) On others, its explicitly set to empty to indicate that it is not supported by the platform Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
785ef7f to
4e59b95
Compare
|
@klueska go-nvlib is now updated to fetch the |
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Co-authored-by: Kevin Klues <klueska@gmail.com> Signed-off-by: Shiva Krishna Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
klueska
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you please squash into a single commit before merging.
|
I still see 4 commits in this PR and on main I see a single commit without a merge commit. How did you merge this? |
With the |
|
In the future, please squash locally and repush so that all merges happen with a merge commit. |
On coherent-memory systems, the possible modes are:
On others, its explicitly set to empty to indicate that it is not supported by the platform