Skip vfio-pci unbind when GPUs already bound in VFIO mode #146
+91
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents unnecessary GPU unbind/rebind operations during rolling updates of the vfio-manager DaemonSet. Currently, k8s-driver-manager unconditionally unbinds all GPUs from vfio-pci on startup, even when the desired state is already vfio-pci. This disrupts active VM workloads using GPU passthrough (KubeVirt, Kata Containers).
This fix checks the node's
nvidia.com/gpu.workload.configlabel to determine if the node is in VFIO mode (vm-passthroughorvm-vgpu). If so, it verifies all GPUs are already bound to vfio-pci variants before proceeding with unbind. If they're already in the correct state, the unbind operation is skipped entirely.Testing
Scenario 1: Rolling update with no state change
nvidia.com/gpu.workload.config=vm-passthroughvfio-pciResult: Unbind was skipped, GPU remained bound through rolling updates
Scenario 2: State transition (nvidia → vfio)
nvidia.com/gpu.workload.config=vm-passthroughResult: Unbind proceeded as expected