Skip to content

Conversation

@alessiodevoto
Copy link
Contributor

@alessiodevoto alessiodevoto commented Aug 1, 2025

PR description

This PR handles migration from poetry to uv, and fixes some minor details. Main contributions:

UV

  • Ported from poetry to uv
  • Better separation for dependecy groups

Additional

  • Added docstring for KVDiffPress and BlockPress
  • Disabled thinking for the pipeline. This is necessary because for some models (e.g. Qwen3) the thinking is automatically true

Checklist

  • Tests are working (make test)
  • Code is formatted correctly (make style, on errors try fix with make format)
  • Copyright header is included
  • All commits are signed-off using git commit -s
  • (new press) mypress_press.py is in the presses directory
  • (new press) MyPress is in __init__.py
  • (new press) README.md is updated with a 1 liner about the new press in the Available presses section
  • (new press) New press is in the default_presses list in tests/default_presses.py
  • (new press) A docstring is provided that follows the same structure as the existing ones

Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
@maxjeblick maxjeblick self-requested a review August 1, 2025 13:40
Copy link
Collaborator

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update, this is really helpful!

I left some comments, most of them minor.
Main points are:

  • We can move flash attention installation to uv, creating a new dependency group.
  • I'm not confident hatchling will work with the current publish pipeline. You can probably test this by creating a new workflow that
    • is triggered on pull_request
    • builds the package but doesn't publish it (we can remove this workflow before merging).

Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Copy link
Collaborator

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding uv!

@alessiodevoto alessiodevoto merged commit 3eb3f92 into main Aug 5, 2025
3 checks passed
@alessiodevoto alessiodevoto deleted the aledev/uv branch August 5, 2025 17:00
maxjeblick pushed a commit that referenced this pull request Aug 12, 2025
Signed-off-by: Max Jeblick <maximilianjeblick@gmail.com>
maxjeblick pushed a commit that referenced this pull request Aug 12, 2025
Signed-off-by: Max Jeblick <maximilianjeblick@gmail.com>
maxjeblick pushed a commit that referenced this pull request Aug 12, 2025
Signed-off-by: Max Jeblick <maximilianjeblick@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants