Add post_init_from_model method #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SimJeg <sjegou@nvidia.com>
Collaborator
Author
|
/ok to test 00a150c |
Collaborator
Author
|
/ok to test 4e178c7 |
Signed-off-by: SimJeg <sjegou@nvidia.com>
Collaborator
Author
|
/ok to test 7ebacd5 |
Signed-off-by: SimJeg <sjegou@nvidia.com>
Collaborator
Author
|
/ok to test 083fe9c |
maxjeblick
reviewed
Dec 2, 2025
maxjeblick
approved these changes
Dec 2, 2025
Collaborator
maxjeblick
left a comment
maxjeblick
left a comment
There was a problem hiding this comment.
Thanks a lot LGTM!
I've left one comment regarding the testing - would be great if you can check it.
Signed-off-by: SimJeg <sjegou@nvidia.com>
Collaborator
Author
|
/ok to test 92f8533 |
Collaborator
Author
|
/ok to test d52e7b1 |
Signed-off-by: SimJeg <sjegou@nvidia.com>
Collaborator
Author
|
/ok to test ffd81cc |
maxjeblick
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the method
__post_init_from_model__in the BasePress as it's already used in 3 different presses