CUDA: add conditions as predicates tests\n\nAdds kernel-based tests f…#734
Open
CodersAcademy006 wants to merge 2 commits intoNVIDIA:mainfrom
Open
CUDA: add conditions as predicates tests\n\nAdds kernel-based tests f…#734CodersAcademy006 wants to merge 2 commits intoNVIDIA:mainfrom
CodersAcademy006 wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
…or device-side boolean conditions: if with comparison, boolean arrays, nested predicates, else branches, and constant predicates. Skips under cudasim. NumPy is used as the reference. Scope is intentionally limited to safe, well-defined CUDA predicate lowering.
Contributor
Greptile SummaryThis PR adds comprehensive test coverage for CUDA device-side boolean conditions and predicate lowering, directly contributing to issue #515. The new test file includes:
The copyright header issue from the previous review has been addressed. All tests follow established patterns in the codebase with proper CUDA kernel structure, device memory management, and synchronization. Confidence Score: 5/5
Important Files Changed
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds kernel-based tests for device-side boolean conditions in Numba-CUDA:
if with comparison predicates
boolean arrays as conditions
nested predicates
else branches
constant predicates
Tests are skipped under cudasim due to divergent semantics, and NumPy is used as the reference oracle. The scope is intentionally limited to safe, well-defined CUDA predicate lowering (no Python truthiness, short-circuit logic, or object conditions).
This continues the systematic porting of CPU-side tests to CUDA, directly contributing to issue #515.