CUDA: add closure tests\n\nAdds kernel-based tests for device-side cl…#735
Open
CodersAcademy006 wants to merge 5 commits intoNVIDIA:mainfrom
Open
CUDA: add closure tests\n\nAdds kernel-based tests for device-side cl…#735CodersAcademy006 wants to merge 5 commits intoNVIDIA:mainfrom
CodersAcademy006 wants to merge 5 commits intoNVIDIA:mainfrom
Conversation
…osure capture: constants, scalars, kernel factories, and read-only captures. Skips under cudasim. NumPy is used as the reference. Scope is intentionally limited to safe, well-defined CUDA closure semantics.
Contributor
Greptile SummaryAdds comprehensive CUDA closure capture tests covering constants, scalars, boolean flags, kernel factories, and multiple constant capture scenarios. All previously identified critical issues (missing SPDX header, weak test assertions, undefined kernel variable, and missing kernel launch) have been resolved.
Confidence Score: 5/5
Important Files Changed
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds kernel-based tests for device-side closure capture in Numba-CUDA:
Constants and scalar values
Kernel factories with closure capture
Read-only captures
Tests are skipped under cudasim due to divergent semantics, and NumPy is used as the reference oracle. The scope is intentionally limited to safe, well-defined CUDA closure semantics (no mutable captures, late binding, or nested closures).
This continues the systematic porting of CPU-side tests to CUDA, directly contributing to issue #515.