-
Notifications
You must be signed in to change notification settings - Fork 57
fix: extract handle value in Event.query() call to match other driver calls #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ccam80
wants to merge
14
commits into
NVIDIA:main
Choose a base branch
from
ccam80:event-query-bug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
55d484a
fix: extract handle value in Event.query() call to match other driver…
ccam80 b698a5d
tests: add regression test for Event.query()
ccam80 876c90f
Apply suggestions from code review
cpcloud 93e7577
Merge branch 'main' into event-query-bug
ccam80 0951c7c
remove unnecessary assertion, clarify failure modes.
ccam80 dc4fb1a
Merge remote-tracking branch 'origin/event-query-bug' into event-quer…
ccam80 f6d3c59
Merge branch 'main' into event-query-bug
ccam80 ddbb792
fix: remove unnecessary busy-wait and time-based assertions.
ccam80 ce8c81a
Merge branch 'main' into event-query-bug
ccam80 1e92818
Merge remote-tracking branch 'origin/event-query-bug' into event-quer…
ccam80 c24fc42
Merge branch 'main' into event-query-bug
ccam80 8138622
fix: fix fragile timing in test_event_query.
ccam80 138411e
Merge branch 'main' into event-query-bug
ccam80 1175800
formatting fix
kkraus14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.