Delegate all path discovery in cuda_paths.py to pathfinder#810
Open
cpcloud wants to merge 3 commits intoNVIDIA:mainfrom
Open
Delegate all path discovery in cuda_paths.py to pathfinder#810cpcloud wants to merge 3 commits intoNVIDIA:mainfrom
cpcloud wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
Replace the manual search-priority infrastructure (conda, wheel,
CUDA_HOME, system) with direct calls to cuda.pathfinder APIs:
- libdevice: pathfinder.locate_bitcode_lib("device")
- cudadevrt: pathfinder.locate_static_lib("cudadevrt")
- nvrtc/nvvm: pathfinder.load_nvidia_dynamic_lib (unchanged)
- include_dir: pathfinder.locate_nvidia_header_directory (unchanged)
Remove ~360 lines of bespoke path-scanning code including
get_system_ctk, get_conda_ctk_libdir, get_cuda_home, wheel
introspection helpers, and the cudalib_dir/static_cudalib_dir
indirection layer.
Requires cuda-pathfinder >= 1.4.0 (locate_bitcode_lib,
locate_static_lib).
Closes NVIDIA/cuda-python#1036
Made-with: Cursor
Contributor
|
Automatic reviews are disabled for this repository. |
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Required for locate_bitcode_lib and locate_static_lib APIs used by the refactored cuda_paths.py. Made-with: Cursor
Made-with: Cursor
Contributor
Author
|
Perhaps this should be in draft mode until the next release of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cuda_paths.pytocuda.pathfinder, removing ~360 lines of bespoke conda/wheel/CUDA_HOME/system search logicpathfinder.locate_bitcode_lib("device")for libdevice andpathfinder.locate_static_lib("cudadevrt")for cudadevrt, replacing thecudalib_dir/static_cudalib_dirindirection layerlibs.pyto a thin wrapper overget_cuda_paths()with no directory-scanning fallbackRequires
cuda-pathfinder >= 1.4.0forlocate_bitcode_libandlocate_static_lib(NVIDIA/cuda-python#1690).Closes NVIDIA/cuda-python#1036
xref NVIDIA/cuda-python#716