Skip to content

Add Tesselation sample_boundary Warp implementation#257

Merged
Alexey-Kamenev merged 7 commits intoNVIDIA:mainfrom
Alexey-Kamenev:tess-warp
Aug 26, 2025
Merged

Add Tesselation sample_boundary Warp implementation#257
Alexey-Kamenev merged 7 commits intoNVIDIA:mainfrom
Alexey-Kamenev:tess-warp

Conversation

@Alexey-Kamenev
Copy link
Collaborator

PhysicsNeMo Pull Request

Description

Added Tesselation sample_boundary Warp implementation.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@Alexey-Kamenev Alexey-Kamenev self-assigned this Aug 11, 2025
@Alexey-Kamenev Alexey-Kamenev added 2 - In Progress Currently a work in progress 3 - Ready for Review Ready for review by team labels Aug 11, 2025
@Alexey-Kamenev
Copy link
Collaborator Author

/blossom-ci

@Alexey-Kamenev
Copy link
Collaborator Author

/blossom-ci

Copy link
Collaborator

@ktangsali ktangsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thanks!

A few questions. Have you verified that the sample_interior and sample_boundary work together? Additionally, it would be great if we documented these additions better.

API Docs: https://github.com/NVIDIA/physicsnemo-sym/blob/main/docs/api/physicsnemo.sym.geometry.rst#geometrytessellation

Features Docs: https://github.com/NVIDIA/physicsnemo-sym/blob/main/docs/user_guide/features/csg_and_tessellated_module.rst#tesselated-geometry

Additionally, would be great to add some speed comparisons. If I understand correctly, the default is not being changed in this PR right?

@ktangsali
Copy link
Collaborator

This is fantastic! Thanks!

A few questions. Have you verified that the sample_interior and sample_boundary work together? Additionally, it would be great if we documented these additions better.

API Docs: https://github.com/NVIDIA/physicsnemo-sym/blob/main/docs/api/physicsnemo.sym.geometry.rst#geometrytessellation

Features Docs: https://github.com/NVIDIA/physicsnemo-sym/blob/main/docs/user_guide/features/csg_and_tessellated_module.rst#tesselated-geometry

Additionally, would be great to add some speed comparisons. If I understand correctly, the default is not being changed in this PR right?

A few speed comparisons would be the cherry on the cake.

@Alexey-Kamenev
Copy link
Collaborator Author

All great comments, thank you!

A few questions. Have you verified that the sample_interior and sample_boundary work together?

Yes! I've confirmed that sample_interior still works with the Warp Tesselator.
I verified it both visually and by comparing the results with the default Tesselator.

Additionally, it would be great if we documented these additions better.
API Docs: https://github.com/NVIDIA/physicsnemo-sym/blob/main/docs/api/physicsnemo.sym.geometry.rst#geometrytessellation

Done.

Features Docs: https://github.com/NVIDIA/physicsnemo-sym/blob/main/docs/user_guide/features/csg_and_tessellated_module.rst#tesselated-geometry
Additionally, would be great to add some speed comparisons. If I understand correctly, the default is not being changed in this PR right?
A few speed comparisons would be the cherry on the cake.

That is correct, the default is not changed in this PR.
I've added documentation and performance comparison table.

@Alexey-Kamenev
Copy link
Collaborator Author

/blossom-ci

@Alexey-Kamenev Alexey-Kamenev merged commit 2a355de into NVIDIA:main Aug 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 - In Progress Currently a work in progress 3 - Ready for Review Ready for review by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants