Add Tesselation sample_boundary Warp implementation#257
Add Tesselation sample_boundary Warp implementation#257Alexey-Kamenev merged 7 commits intoNVIDIA:mainfrom
Conversation
|
/blossom-ci |
|
/blossom-ci |
ktangsali
left a comment
There was a problem hiding this comment.
This is fantastic! Thanks!
A few questions. Have you verified that the sample_interior and sample_boundary work together? Additionally, it would be great if we documented these additions better.
Features Docs: https://github.com/NVIDIA/physicsnemo-sym/blob/main/docs/user_guide/features/csg_and_tessellated_module.rst#tesselated-geometry
Additionally, would be great to add some speed comparisons. If I understand correctly, the default is not being changed in this PR right?
A few speed comparisons would be the cherry on the cake. |
|
All great comments, thank you!
Yes! I've confirmed that
Done.
That is correct, the default is not changed in this PR. |
|
/blossom-ci |
PhysicsNeMo Pull Request
Description
Added
Tesselationsample_boundaryWarp implementation.Checklist
Dependencies