Skip to content

Update zero eq#235

Merged
ktangsali merged 3 commits intoNVIDIA:mainfrom
ktangsali:update-zero-eq
Apr 16, 2025
Merged

Update zero eq#235
ktangsali merged 3 commits intoNVIDIA:mainfrom
ktangsali:update-zero-eq

Conversation

@ktangsali
Copy link
Collaborator

@ktangsali ktangsali commented Apr 15, 2025

PhysicsNeMo Pull Request

Description

The present PDE included turbulent dynamic viscosity. However, since the PDE describes the overall kinematic viscosity, the rho term needs to be dropped. After that is completed, the units match.

Other examples in PhysicsNeMo are unaffected as all of them set rho to 1, so no changes are required there.

Closes: #118

Math

$$ \mu_t = \rho l^2_m \sqrt{G} $$ $$ \rho = kg / m^3, l_m = m, G = 1/s^2 $$ $$ RHS = \rho l^2_m \sqrt{G} = \frac{kg}{m s} $$ $$ LHS = \mu_t = \frac{kg}{m s} $$

Ref

Hence,

$$ \nu_t = m^2 / s $$

Ref

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@ktangsali
Copy link
Collaborator Author

/blossom-ci

@ktangsali
Copy link
Collaborator Author

/blossom-ci

@ktangsali ktangsali merged commit 1ce984f into NVIDIA:main Apr 16, 2025
1 check passed
@ktangsali ktangsali deleted the update-zero-eq branch April 16, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛[BUG]: zero equation model

2 participants