Interpolation model example #1246

jleinonen · 2025-11-24T08:37:24Z

PhysicsNeMo Pull Request

On request by @CharlelieLrt, opening PR corresponding to #1149 but against the main branch.

Description

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.
The CHANGELOG.md is up to date with these changes.
An issue is linked to this pull request.

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

style guide edits

Signed-off-by: Charlelie Laurent <[email protected]>

…odulus into interp-model-example

Signed-off-by: Charlelie Laurent <[email protected]>

github.com:jleinonen/modulus into interp-model-example Merge changes from CharlelieLrt

Signed-off-by: Charlelie Laurent <[email protected]>

…LOG.md Signed-off-by: Charlelie Laurent <[email protected]>

Signed-off-by: Charlelie Laurent <[email protected]>

…odulus into interp-model-example

* Remove pyevtk * update dependency * update dimensions * ci issues

jleinonen · 2025-11-24T08:37:41Z

/blossom-ci

greptile-apps · 2025-11-24T08:43:28Z

Greptile Overview

Greptile Summary

Adds a new temporal interpolation example for weather forecasting using ModAFNO, including training scripts, datapipes, utilities, and comprehensive documentation. Also includes version bump to 1.3.0, dependency updates (einops, requests), and unrelated changes to Gray-Scott example (pyevtk → pyvista migration).

Key additions:

Complete temporal interpolation training pipeline with ModAFNO model
Custom InterpClimateDatapipe for loading interpolation training sequences
Latitude-weighted geometric L2 loss for weather data
Training and validation scripts with distributed training support
Configuration files for production and test runs
Comprehensive README with setup and usage instructions

Issues found:

Missing datetime import in validate.py:268 will cause runtime error when running validation script

Important Files Changed

File Analysis

Filename	Score	Overview
examples/weather/temporal_interpolation/validate.py	3/5	validation script with missing datetime import on line 268
examples/weather/temporal_interpolation/train.py	5/5	main training script with well-structured datapipe, model, and trainer setup
examples/weather/temporal_interpolation/datapipe/climate_interp.py	5/5	custom datapipe for interpolation training extending ClimateDatapipe
examples/weather/temporal_interpolation/utils/trainer.py	5/5	training loop with checkpoint management, validation, and wandb logging

greptile-apps

_{20 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2025-11-24T08:43:27Z

examples/weather/temporal_interpolation/validate.py

+        },
+        attrs={
+            "description": "Histogram of squared errors for temporal interpolation",
+            "created": datetime.now().isoformat(),


syntax: missing import for datetime

Suggested change

"created": datetime.now().isoformat(),

"created": datetime.datetime.now().isoformat(),

…nto interp-model-example

jleinonen · 2025-11-24T10:54:06Z

/blossom-ci

coreyjadams

Hi @jleinonen - I haven't reviewed the PR, really, I'll let others get into the examples.

This PR has several changes that were fixed for the release that aren't here. I am not sure why, we'll track it down. You will likely have to rebase your PR off of that and undo some of these miscellaneous changes, please.

In the meantime, we shouldn't change the version number in this PR.

coreyjadams · 2025-11-24T15:02:06Z

physicsnemo/__init__.py

 from .models.module import Module

-__version__ = "1.3.0a0"
+__version__ = "1.3.0"


We shouldn't be changing the software version this commit.

@ktangsali are you code owner on physicsnemo/__init__.py? If not, we should ensure that :)

coreyjadams · 2025-11-24T15:07:50Z

physicsnemo/utils/neighbors/radius_search/_warp_impl.py

 from physicsnemo.utils.version_check import check_min_version

-WARP_AVAILABLE = check_min_version("warp", "0.6.0")
+WARP_AVAILABLE = check_min_version("warp", "0.6.0", hard_fail=False)


This was fixed in QA for release ...

coreyjadams · 2025-11-24T15:08:03Z

pyproject.toml

+    "einops>=0.8.0",
    "fsspec>=2023.1.0",
    "numpy>=1.22.4",
    "onnx>=1.14.0",
    "packaging>=24.2",
+    "requests>=2.32.2",


These were fixed in QA for release ...

coreyjadams · 2025-11-24T15:08:14Z

test/datapipes/test_domino_datapipe.py

            "stl_faces": faces.astype(np.int32).flatten(),
            "stl_centers": centroids.astype(np.float32),
            "stl_areas": areas.astype(np.float32),
-            "air_density": np.float32(1.225),  # Standard air density


This was addressed during QA for release ...

jleinonen and others added 30 commits October 3, 2025 06:35

Temporal interpolation training recipe

b0dbf92

Add README

af84a7b

Merge branch 'NVIDIA:main' into interp-model-example

d9841bc

Docs changes based on comments

f56991e

Update docstrings and README

ae6eed1

Add temporal interpolation animation

5430eb4

Merge branch 'NVIDIA:main' into interp-model-example

84289f5

Add animation link

2b2c81e

Add shape check in loss

6f09aa1

Updates of configs + trainer

811a38a

Update config comments

cb23fe6

Merge branch 'NVIDIA:main' into interp-model-example

c32a01b

Merge branch 'main' into interp-model-example

f642d78

Update README.md

8d6ae42

style guide edits

Added wandb logging

e1c202b

Signed-off-by: Charlelie Laurent <[email protected]>

Merge branch 'interp-model-example' of https://github.com/jleinonen/m…

dc2b215

…odulus into interp-model-example

Reformated sections in docstring for GeometricL2Loss

a253d6e

Signed-off-by: Charlelie Laurent <[email protected]>

Merge branch 'main' into interp-model-example

aad2683

Update README and configs

e25aaeb

Merge branch 'interp-model-example' of

2ea2897

github.com:jleinonen/modulus into interp-model-example Merge changes from CharlelieLrt

README changes + type hint fixes

8475e1d

Update README.md

547f10d

Merge branch 'NVIDIA:main' into interp-model-example

41560fc

Draft of validation script

5912555

Update validation and README

2a6c06a

Merge branch 'NVIDIA:main' into interp-model-example

06d6aa3

Update version (NVIDIA#1193)

3c13946

Fix depenedncies to enable hello world (NVIDIA#1195)

67fc2c6

Remove zero-len arrays from test dataset (NVIDIA#1198)

14e0874

Merge branch '1.3.0-rc' into interp-model-example

62b8174

CharlelieLrt and others added 13 commits October 30, 2025 16:32

Fixed command in README.md for temporal_interpolation example

551486e

Signed-off-by: Charlelie Laurent <[email protected]>

Removed unused import in datapipe/climate_interp.py

d0d2214

Signed-off-by: Charlelie Laurent <[email protected]>

Updated license headers in temporal_interpolation example

2792ae6

Signed-off-by: Charlelie Laurent <[email protected]>

Renamed methods to avoid implicit shadowing in Trainer class

f600d13

Signed-off-by: Charlelie Laurent <[email protected]>

Cosmetic changes in train.py and removed unused import in validate.py

f1fd540

Signed-off-by: Charlelie Laurent <[email protected]>

Added clamp in validate.py to make sure step does not go out of bounds

2b8de5c

Signed-off-by: Charlelie Laurent <[email protected]>

Added the temporal_interpolation example to the docs + updated CHANGE…

d719952

…LOG.md Signed-off-by: Charlelie Laurent <[email protected]>

Addressing remaining comments

390d778

Merged two data source classes in climate_interp.py

e6477aa

Signed-off-by: Charlelie Laurent <[email protected]>

Merge branch 'interp-model-example' of https://github.com/jleinonen/m…

04729dd

…odulus into interp-model-example

Merge updates to Gray Scott example (NVIDIA#1239)

1ce70ca

* Remove pyevtk * update dependency * update dimensions * ci issues

Merge branch '1.3.0-rc' into interp-model-example

bdd7c71

Merge branch 'NVIDIA:main' into interp-model-example

7d26c7b

jleinonen self-assigned this Nov 24, 2025

jleinonen requested review from coreyjadams, ktangsali, megnvidia and peterdsharpe as code owners November 24, 2025 08:37

greptile-apps bot reviewed Nov 24, 2025

View reviewed changes

jleinonen added 3 commits November 24, 2025 02:51

Restore missing datetime import

b2d7d4e

Merge branch 'interp-model-example' of github.com:jleinonen/modulus i…

e507b46

…nto interp-model-example

Restore missing datetime import

8c38ae3

coreyjadams requested changes Nov 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Interpolation model example #1246

Interpolation model example #1246

Uh oh!

jleinonen commented Nov 24, 2025

Uh oh!

jleinonen commented Nov 24, 2025

Uh oh!

greptile-apps bot commented Nov 24, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Nov 24, 2025

Uh oh!

jleinonen commented Nov 24, 2025

Uh oh!

coreyjadams left a comment

Uh oh!

coreyjadams Nov 24, 2025

Uh oh!

coreyjadams Nov 24, 2025

Uh oh!

coreyjadams Nov 24, 2025

Uh oh!

coreyjadams Nov 24, 2025

Uh oh!

coreyjadams Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	"created": datetime.now().isoformat(),
	"created": datetime.datetime.now().isoformat(),

Interpolation model example #1246

Are you sure you want to change the base?

Interpolation model example #1246

Uh oh!

Conversation

jleinonen commented Nov 24, 2025

PhysicsNeMo Pull Request

Description

Checklist

Dependencies

Review Process

Uh oh!

jleinonen commented Nov 24, 2025

Uh oh!

greptile-apps bot commented Nov 24, 2025

Greptile Overview

Greptile Summary

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

jleinonen commented Nov 24, 2025

Uh oh!

coreyjadams left a comment

Choose a reason for hiding this comment

Uh oh!

coreyjadams Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

coreyjadams Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

coreyjadams Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

coreyjadams Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

coreyjadams Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants