Skip to content

Conversation

@ktangsali
Copy link
Collaborator

PhysicsNeMo Pull Request

Description

Added new use cases and models for CFD, Weather, Structural Mechanics, Healthcare, and Generative sections in the README.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

Added new use cases and models for CFD, Weather, Structural Mechanics, Healthcare, and Generative sections in the README.
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 26, 2025

Greptile Overview

Greptile Summary

This PR updates the examples README by adding new models and use cases across multiple domains. New additions include DoMINO NIM fine-tuning and Transolver for CFD, crash dynamics for structural mechanics, reservoir simulation using X-MeshGraphNet, and an active learning section.

Critical Issues:

  • The Temporal Interpolation Model entry references a non-existent directory (./weather/temporal_interpolation/)
  • Three new entries use inconsistent path formats with ./examples/ prefix instead of the relative paths used throughout the file

Other Changes:

  • Removed several entries from CFD and Weather tables (Vortex Shedding, Darcy variants, Stokes Flow, LDC, FCN-AFNO, Pangu) - these remain in the introductory examples section
  • Added new Geophysics subsection for Reservoir Simulation
  • Added new Active Learning section

Important Files Changed

File Analysis

Filename Score Overview
examples/README.md 2/5 Added new examples to CFD, Weather, Structural Mechanics, Geophysics, and Active Learning sections; removed some entries from CFD/Weather tables (now in introductory section); contains broken path reference to non-existent temporal_interpolation directory and inconsistent path formats

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. examples/README.md, line 69 (link)

    logic: the directory ./weather/temporal_interpolation/ does not exist in the repository

1 file reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

ktangsali and others added 2 commits November 26, 2025 21:30
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@ktangsali
Copy link
Collaborator Author

/blossom-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants