Merged
Conversation
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
cdesiniotis
commented
Mar 8, 2025
Comment on lines
+2572
to
+2579
| - device-filter: "0x232C10DE" | ||
| devices: all | ||
| vgpu-devices: | ||
| H20X-70C: 2 | ||
| - device-filter: "0x232C10DE" | ||
| devices: all | ||
| vgpu-devices: | ||
| H20X-70C: 2 |
Contributor
Author
There was a problem hiding this comment.
Note: there is a minor bug in the tool that generates this yaml file -- it will add duplicate entries in the default config entry whenever a device id (e.g. 0x232C10DE) has multiple devices associated with it, each having a different subsystem ID. Having a duplicate entry here is not a functional issue, but it would be good to eventually update our config-gen tool to clean up duplicate entries in the default config.
tariq1890
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.