Open
Conversation
moraaar
commented
Jan 18, 2021
- Added support to build both share & static libraries on all platforms (pc, mac, ios, android, linux)
- Modified cmake files to be able to choose between static or dynamic libraries
- Predefined NvCloth API macros when building staticly so it doesn't include any export/import code.
- Fixed linking error on iOS as it didn't include any implementation for Atomics (using unix version as Mac does)
- Fixed Windows cmake bug when choosing between /MT and /MD.
- Fixed linking error when NEON is enabled caused by compiling SwCollision.cpp, SwSelfCollision.cpp and SwSolverKernel.cpp content twice.
- Enabled NEON SIMD instructions on all platforms that supports it:
- Modified NEON code to be platform agnostic using macros, not Android only.
- Enbled NEON instructions on iOS
- Modified Android cmake files to use the right macros depending on ABI being built.
- Fixed compilation error when client app uses NvCloth library and the app compiles with Visual Studio 2019.
- Microsoft removed <typeinfo.h> from VS2019 16.3 and that header is used by NvCloth library. Fixed nVidia's NvCloth library to use instead from that version.
- Fixed unstable cloth simulation on Android (armv8).
- Cloth particles during simulation were very unstable on Android (armv8), their location gets out of control really quickly with very unpredictable behaviour. After many attempts to find the source of the problem debugging the library, the solution came by adding the flag "-ffast-math" in the compilation of the library for Android (armv8).
…ms (pc, mac, ios, android, linux)
+ Modified cmake files to be able to choose between static or dynamic libraries
+ Predefined NvCloth API macros when building staticly so it doesn't include any export/import code.
- Fixed linking error on iOS as it didn't include any implementation for Atomics (using unix version as Mac does)
- Fixed Windows cmake bug when choosing between /MT and /MD.
- Fixed linking error when NEON is enabled caused by compiling SwCollision.cpp, SwSelfCollision.cpp and SwSolverKernel.cpp content twice.
- Enabled NEON SIMD instructions on all platforms that supports it:
+ Modified NEON code to be platform agnostic using macros, not Android only.
+ Enbled NEON instructions on iOS
+ Modified Android cmake files to use the right macros depending on ABI being built.
- Fixed compilation error when client app uses NvCloth library and the app compiles with Visual Studio 2019.
+ Microsoft removed <typeinfo.h> from VS2019 16.3 and that header is used by NvCloth library. Fixed nVidia's NvCloth library to use <typeinfo> instead from that version.
- Fixed unstable cloth simulation on Android (armv8).
+ Cloth particles during simulation were very unstable on Android (armv8), their location gets out of control really quickly with very unpredictable behaviour. After many attempts to find the source of the problem debugging the library, the solution came by adding the flag "-ffast-math" in the compilation of the library for Android (armv8).
|
Good job, fix unstable cloth simulation problem in my test app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.