Skip to content

put wandb setup first in _setup_dashboards and arrange cast data pass… #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barikata1984 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

put wandb setup first in _setup_dashboards and arrange cast data pass… #184

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8174663
put wandb setup first in _setup_dashboards and arrange cast data pass…
barikata1984 Nov 7, 2023
04f07d9
cast data.keys() into a list as well
barikata1984 Nov 7, 2023
6981366
Merge branch 'NVIDIAGameWorks:main' into bugfix/init_wandb_and_log_table
barikata1984 Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions wisp/trainers/tracker/tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,16 +178,6 @@ def _setup_dashboards(cfg: ConfigTracker, exp_name: str, log_fname: str):
This function is invoked from the Tracker constructor, and must run before performing any experiment logging.
"""
dashboards: Dict[str, _BaseDashboard] = dict()
if cfg.enable_tensorboard:
if cfg.tensorboard.exp_name is None:
cfg.tensorboard.exp_name = exp_name
if cfg.tensorboard.log_fname is None:
cfg.tensorboard.log_fname = log_fname
if _TENSORBOARD_AVAILABLE:
dashboards['tensorboard'] = instantiate(cfg.tensorboard)
else:
log.warning("Tensorboard experiment tracking enabled, "
"but couldn't import torch.utils.tensorboard.SummaryBoard")
if cfg.enable_wandb:
if cfg.wandb.entity is None:
raise Exception("You must set your username as the entity to use Wandb")
Expand All @@ -201,6 +191,16 @@ def _setup_dashboards(cfg: ConfigTracker, exp_name: str, log_fname: str):
dashboards['wandb'] = instantiate(cfg.wandb)
else:
log.warning("wandb experiment tracking enabled, but couldn't import wandb")
if cfg.enable_tensorboard:
if cfg.tensorboard.exp_name is None:
cfg.tensorboard.exp_name = exp_name
if cfg.tensorboard.log_fname is None:
cfg.tensorboard.log_fname = log_fname
if _TENSORBOARD_AVAILABLE:
dashboards['tensorboard'] = instantiate(cfg.tensorboard)
else:
log.warning("Tensorboard experiment tracking enabled, "
"but couldn't import torch.utils.tensorboard.SummaryBoard")
return dashboards

def teardown(self):
Expand Down Expand Up @@ -450,7 +450,7 @@ def teardown(self):
wandb.finish()

def log_table(self, caption: str, data: Dict[str, Any], step=None):
table = wandb.Table(columns=data.keys(), data=data.values())
table = wandb.Table(columns=[*data.keys()], data=[[*data.values()]])
wandb.log({caption: table}, step=step, commit=False)

def log_metric(self, metric, value, step=None):
Expand Down