Skip to content

Conversation

@fvankrieken
Copy link
Contributor

@fvankrieken fvankrieken commented Jan 7, 2026

So per email with MC from DOB, it would be great if we could use CofO data from OpenData instead of a manual export that he emails us. Like applications and permits, there's one each for BIS and NOW

We can't actually use these yet - the NOW data doesn't have number of units, which we currently use from the custom export from MC. He says that they're working on getting those fields on OpenData. But since I wrote these, I figured it'd be nice to at least have these new ingest templates.

Also, while comparing data, I found that the logic we use to get devdb info from the c of o table was a little fussy, so I simplified the query. Tested this new query against a build on main

select * from 
(select * from fvk_cofos.co_devdb except all select * from nightly_qa.co_devdb) a
union all
select * from 
(select * from nightly_qa.co_devdb except all select * from fvk_cofos.co_devdb) b

No rows returned

Build here

@fvankrieken fvankrieken changed the title Fvk cofos slight tweaks with devdb cos Jan 7, 2026
@fvankrieken fvankrieken marked this pull request as ready for review January 7, 2026 17:57
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.68%. Comparing base (a0072b6) to head (edac95c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fvankrieken fvankrieken force-pushed the fvk-cofos branch 2 times, most recently from e986558 to 1ad35a6 Compare January 7, 2026 19:22
@fvankrieken fvankrieken merged commit 2ff36fe into main Jan 8, 2026
39 checks passed
@fvankrieken fvankrieken deleted the fvk-cofos branch January 8, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants