Skip to content

Conversation

@alexrichey
Copy link
Contributor

@alexrichey alexrichey commented Jan 8, 2026

per Sam and Talia, we should never pull from anything other than zonedist1, and we should not split. This came out of investigating what null vs "-" mean in the dcp_zoning_maxfar.csv file from zoning.

Luckily, only 26 BBLs had incorrect FAR values in PLUTO due to this bug. They're below. We can review now, but I'm going to wait to merge until chatting with @AmandaDoyle, who probably wrote this code originally.

BBL new_facilfar old_facilfar new_commfar old_commfar new_residfar old_residfar
1002030025 0 6.5 6 6 3.44 3.44
1002390029 0 6.5 6 6 3.44 3.44
1010110001 10 10 0 4 10 10
1010110038 10 10 0 4 10 10
1012740006 10 10 0 4 10 10
1002390027 0 6.5 6 6 3.44 3.44
1010110052 10 10 0 4 10 10
1001170100 0 6.5 6 6 3.44 3.44
1002030021 0 6.5 6 6 3.44 3.44
1013750001 10 10 0 4 10 10
1002000020 0 6.5 6 6 3.44 3.44
1004240040 0 7.5 6 6 3.44 3.44
1012747503 10 10 0 4 10 10
1010110042 10 10 0 4 10 10
1001627501 0 6.5 6 6 3.44 3.44
1001620042 0 6.5 6 6 3.44 3.44
1001620033 0 6.5 6 6 3.44 3.44
1002030020 0 6.5 6 6 3.44 3.44
1001990017 0 6.5 6 6 3.44 3.44
1004230030 0 7.5 6 6 3.44 3.44
1002010011 0 6.5 6 6 3.44 3.44
1002800052 0 6.5 6 6 3.44 3.44
1004780036 0 6.5 6 6 3.44 3.44
1001620041 0 6.5 6 6 3.44 3.44
1004230009 0 7.5 6 6 3.44 3.44
1012747504 10 10 0 12 10 10

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.68%. Comparing base (bc8faa2) to head (e6d3670).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexrichey alexrichey marked this pull request as ready for review January 8, 2026 19:50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we still have a mix of dashes and nulls for resdisteq. Doesn't necessarily seem 100% in scope but do you have thoughts there? I don't think it's used in the build currently actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants