Ar pluto new fields 1892 p2#2221
Open
alexrichey wants to merge 10 commits intoar-pluto-new-fields-1893from
Open
Ar pluto new fields 1892 p2#2221alexrichey wants to merge 10 commits intoar-pluto-new-fields-1893from
alexrichey wants to merge 10 commits intoar-pluto-new-fields-1893from
Conversation
alexrichey
force-pushed
the
ar-pluto-new-fields-1892-p2
branch
5 times, most recently
from
24b6699 to
197488f
Compare
alexrichey
force-pushed
the
ar-pluto-new-fields-1892-p2
branch
from
197488f to
0dc5f9e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexrichey
force-pushed
the
ar-pluto-new-fields-1892-p2
branch
from
049e817 to
c877148
Compare
alexrichey
force-pushed
the
ar-pluto-new-fields-1892-p2
branch
from
c877148 to
f38c00b
Compare
alexrichey
force-pushed
the
ar-pluto-new-fields-1892-p2
branch
from
385e5fd to
8657b7d
Compare
alexrichey
force-pushed
the
ar-pluto-new-fields-1892-p2
branch
from
8657b7d to
aa32610
Compare
alexrichey
force-pushed
the
ar-pluto-new-fields-1892-p2
branch
from
889d748 to
e49eb2b
Compare
- Add dcp_transit_zone_ranks.csv lookup table with 5 transit zones ranked 1-4 - Update _create.sql to load transit zone ranks table - Modify transitzone.sql to prioritize zones with tz_rank < 4 over 'Beyond the Greater Transit Zone' in lot-level assignments - If a lot has ANY coverage in a zone with rank < 4, exclude rank 4 zones from consideration Closes data-engineering-vu1.1, data-engineering-vu1.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites MIH Areas and Transit Zone assignments based on our meeting with folks from Transit and Zoning. For logic on the assignments, see the sql files themselves.
Alas, I don't have a passing build to link here - the last one failed on the dbt QA stuff due to a mistake by me. After our demo, I'm going to re-run the build which should pass.
For the QA views, they're mostly to help diagnose/demo/visualize the edge cases. The tables look like this:
Which allows you to visualize all the relevant geometries in a single row.
note I've got this pointed at the previous PR, so you can see what changed between then and now. Feel free to change to point at
mainso you can see all changes. Also, I'm going to wait to merge this until QA is finished so that (if necessary) we can still build pluto without these changes.