Open
Conversation
- Update categorized CTE to use usetype_mapped instead of normed_name_merge - This ensures cleaned usetype values from usetype_mappings seed are used - All 75 mapped values now display cleaned versions in final COLP output - Closes de-3oz.3
85118d9 to
6f5991b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USE TYPES
Unfortunately (see here) DCAS IPIS usetypes changed from full to truncated versions. We should ask them about this, but in the meantime it was easy enough to just make a translations table from the newer truncated types (e.g. "POLLUTION CONTRL FAC") to the older versions ("POLLUTION CONTROL FACILITY") to maintain stability.
There are only two newer truncated types that we're seeing now, but haven't seen before:
"EMERGENCY MEDICL STN"
"COURT (SPORTS)"
I'm going to leave these be. All other types are accounted for.
OTHER REFACTORS
I don't have geosupport locally, so I broke the scripts apart to enable running just the sql part of things.