Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

WIP: docker image testing#354

Draft
td928 wants to merge 9 commits intomainfrom
352-docker-image-testing
Draft

WIP: docker image testing#354
td928 wants to merge 9 commits intomainfrom
352-docker-image-testing

Conversation

@td928
Copy link
Contributor

@td928 td928 commented Dec 28, 2022

#352 still a work in progress

recall the lack of functionality to test the staging docker image. This is an attempt to get at that by creating a dummy template to run a datasets.

But you can also see that by adding the subfolder options under destination here:

  destination:
    name: *name
    subfolder: test_docker_

and some modification in the ingestor function it could achieved such that one can dictate using the template to whether send any datasets to their default folder or under a "subfolder" which in this case is test_docker_. This additional layer solves our issue of adding something potentially only for testing to our production datasets folders.

Next Steps

This in my mind could eventually be formalized into a workflow where a data matrix could be iterated over like we do in the weekly update workflow and then passing the subfolder as an option like:

jobs:
  dataloading:
    runs-on: ubuntu-latest
    env:
      AWS_S3_ENDPOINT: ${{ secrets.DO_S3_ENDPOINT }}
      AWS_ACCESS_KEY_ID: ${{ secrets.DO_ACCESS_KEY_ID }}
      AWS_SECRET_ACCESS_KEY: ${{ secrets.DO_SECRET_ACCESS_KEY }}
      AWS_S3_BUCKET: edm-recipes
    steps:
      - uses: actions/checkout@v2.3.4
      - uses: NYCPlanning/action-library-archive@v1.2
        name: Archive test_docker
        with:
          name: ${{ github.event.inputs.dataset }}
          subfolder: test
          latest: ${{ github.event.inputs.latest }}
          version: ${{ github.event.inputs.version }}
          s3: true
          compress: true
          output_format: pgdump shapefile csv

then it would send a few datasets for testing to the test folder on digital ocean for review.

@td928 td928 added the wip label Dec 28, 2022
@td928 td928 requested review from AmandaDoyle and mbh329 December 28, 2022 14:35
@damonmcc damonmcc removed the wip label Apr 3, 2023
@damonmcc damonmcc marked this pull request as draft April 23, 2023 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants