This repository was archived by the owner on Oct 2, 2023. It is now read-only.
Open
Conversation
Contributor
|
Contributor
|
regarding library/script/dcp_cpdb.py:
|
athursland
reviewed
Jul 19, 2023
library/templates/dcp_cpdb.yml
Outdated
|
|
||
| info: | ||
| description: | | ||
| Checkbook NYC Spending API: https://www.checkbooknyc.com/spending-api |
Contributor
There was a problem hiding this comment.
I would include a more detailed description, maybe also without the Checkbook NYC link (since this YAML is just for the CPDB geometries). We could include a brief overview of what CPDB is and what kind of data this is (points and polygons)
athursland
reviewed
Jul 19, 2023
Contributor
There was a problem hiding this comment.
this file can be deleted since nycoc_checkbook.yml was already merged to main
athursland
suggested changes
Jul 19, 2023
Contributor
athursland
left a comment
There was a problem hiding this comment.
delete nycoc_checkbook,yml, delete library/script/dcp_cpdb.py, update description in dcp_cpdb.yml, update path/subpath specs in dcp_cpdb.yaml to dump all of the geometries to digital ocean
fvankrieken
reviewed
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a manual loading YML for the CDPB historical projects + made a python script for merging different CPDB files together. Added NYCOC Checkbook YML that reads in checkbook data