Merged
Conversation
elvisdragonmao
approved these changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a global toast context by wrapping the application router with ToastProvider, enabling toast UI to be rendered across routes.
Changes:
- Import
ToastProviderfrom shared components. - Wrap
AppRouterwithToastProviderinApp.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5
to
+8
| return ( | ||
| <ToastProvider> | ||
| <AppRouter /> | ||
| </ToastProvider> |
There was a problem hiding this comment.
Wrapping the whole app in ToastProvider means any route/component that also mounts its own ToastProvider will create nested Radix toast providers/viewports. In this repo, ComponentsDemo already wraps itself in , so visiting /demo will render two toast viewports and can lead to duplicated UI/stacking issues. Consider removing the inner ToastProvider usage (or otherwise ensuring only a single provider is mounted at a time).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Purpose
ToastProviderto wrapAppRouter