Fix vault paths, enable itest coverage, and display coveralls coverage badge#24
Open
aakselrod wants to merge 3 commits intoNYDIG-OSS:mainfrom
Open
Fix vault paths, enable itest coverage, and display coveralls coverage badge#24aakselrod wants to merge 3 commits intoNYDIG-OSS:mainfrom
aakselrod wants to merge 3 commits intoNYDIG-OSS:mainfrom
Conversation
Member
Author
|
@jwelsh-nydig Can you take a look at this and let me know if this is what you want? I can't request you as a reviewer but would like your eyes on it. |
88d6795 to
bcd596e
Compare
bcd596e to
b1f9732
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
vaultplugin paths to ensure that the node ID is in the path rather than in query parameters for the methodssign,ecdh, andaccounts. This allows the node ID to be specified in granular ACLs to allow user assignment with various privileges to nodes.For example, a user can have access to
lnd-nodes/nodeApubkeybut notlnd-nodes/nodeBpubkey. Alternatively, a user could have access tolnd-nodes/nodeApubkey/ecdhandlnd-nodes/nodeApubkey/accounts, but notlnd-nodes/nodeApubkey/sign, while having access to all oflnd-nodes/nodeBpubkeypaths.The PR also updates tests to work with the new path format, the README.md instructions, and adds an integration test to show that the node specified in the path isn't overridden by a query parameter specifying the node. This fixes #22.
The PR then updates
lndandbitcoindto the latest version, andvaultto the version we use in our testnet sandbox.Finally, the PR updates the integration tests to ensure
lndsignerdandvault-plugin-lndsignerexit cleanly at the end of the tests, and enables coverage analysis on the integration tests. This fixes #21.