DRAFT: NO_REF / Add slow-flag to media-asset check that consistently has to retry in CI#528
Draft
DRAFT: NO_REF / Add slow-flag to media-asset check that consistently has to retry in CI#528
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jbdalton
force-pushed
the
no_ref/increase-tries-for-slow-media-test-CI
branch
from
e37770b to
8865c6f
Compare
jbdalton
force-pushed
the
no_ref/increase-tries-for-slow-media-test-CI
branch
from
8865c6f to
e55388f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket:
This PR does the following:
Noticed one of the test-blocks in the check-media spec consistently has to re-run on CI, or even fails outright the first time, then works on a hard, manual kick.
Adding playwright's
test(slow);flag to the offending block, to see if this increases the chance of the retry being successful when running the whole suite.Open questions
How has this been tested? How should a reviewer test this?
Testing will mainly be checked in the CI itself, since various flags can be added locally to the cmd-line etc to try out various retry strategies for slow or flakey test scenarios.
This approach,
test(slow);, is at least file-specific, and doesn't mess with existing global CI settings. It's worked as expected on my localhost when running the whole suite at the--workers=2setting. Which is to say it pauses the offending block long enough, it seems, that the inevitable retry has been successful on localhost.Accessibility concerns or updates
Checklist: