Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Closed
Contributor
Author
|
Playwright tests will fail on this PR since the backend changes are not yet available on the QA env. |
to see if it is causing the test failures
to allow running diagnostic without asyncpg installed also code comment updates
….com/NYPL/digital-research-books into NOREF/conversation-id-feature-branch
Member
|
@jackiequach could you please resolve the conflicts? |
alea12
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCHOL-453
Describe your changes
Frontend
messagein the payload for the /chat request.Backend
require_session_jwtdecorator that reads the session cookie on each request, verifies the JWT, or issues a new signed session on first visit.session_jwt.pywith helper methods to sign and verify sessions.How to test
Will require updates to end to end smoke tests @jdohan
Frontend/End-to-end
Run the backend locally pointing to the prod db:
Run the frontend:
Go to localhost:3000/research-assistant
Send a message and ensure the vraSessionId is created in the browser's session storage.
Check the
agent_messagestable to make sure the messages associated with the test session ID andagent_sessionsBackend only