Skip to content

Scc 4549/phys override spec#466

Merged
charmingduchess merged 7 commits intomainfrom
SCC-4549/phys-override-spec
Mar 13, 2025
Merged

Scc 4549/phys override spec#466
charmingduchess merged 7 commits intomainfrom
SCC-4549/phys-override-spec

Conversation

@charmingduchess
Copy link
Contributor

https://newyorkpubliclibrary.atlassian.net/browse/SCC-4549

  • refactor physRequestable function to be extremely explicit about what determines physical requestability
  • removes finding aid from spec requestability criteria
  • removes specRequestable overriding physRequestable. Looking closer at our nypl-core data, I'm pretty sure this is not necessary at all. All but two special collections locations are actually listed as requestable: false. I do think these locations should be updated to false, but it doesn't affect this work, because they don't have any deliverableTo locations anyway. Similarly, I believe we should leave all the deliverableTo locations, but it doesn't actually impact this work.
  • update one fixture with extant customer code

This update should be QA'd pretty closely, looking at examples that:

  • have deliverableTo and special collections locations
  • have requestable:false, no delivery locations, and special collections access type
  • are partner records mentioned in the ticket

@charmingduchess charmingduchess requested a review from nonword March 6, 2025 14:51
Copy link
Member

@nonword nonword left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems much cleaner to me!

@charmingduchess charmingduchess merged commit 7ee942a into main Mar 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants