Support multi-word prefixes in "containing" search #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danamansana
approved these changes
Jan 6, 2026
| bool: { | ||
| should: [ | ||
| { match: { preferredTerm: { query: this.request.querySansQuotes(), operator: 'and', _name: 'preferredTerm' } } }, | ||
| { match_bool_prefix: { preferredTerm: { query: this.request.querySansQuotes(), operator: 'and', _name: 'preferredTermMatchBoolPrefix' } } }, |
Contributor
There was a problem hiding this comment.
Does match_bool_prefix make the prefix query redundant?
Contributor
Author
There was a problem hiding this comment.
You're right- it is redundant, good call. I also realized that match_bool_prefix doesn't properly support out-of-order queries like "library catalog" vs "catalog library" so I updated this PR to support that with a simple list comprehension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://newyorkpubliclibrary.atlassian.net/browse/SCC-5059
New York Public Library Catalogwould not pick up the results from the plural searchNew York Public Library Catalogs. Essentially it just does a per-word prefix search alongside the existingcontainsconditions.