Skip to content

ISW-5431: double style bug for custom svgs#1958

Merged
bigfishdesign13 merged 2 commits intodevelopmentfrom
ISW-5431/icon-styles-bug
Mar 3, 2026
Merged

ISW-5431: double style bug for custom svgs#1958
bigfishdesign13 merged 2 commits intodevelopmentfrom
ISW-5431/icon-styles-bug

Conversation

@bigfishdesign13
Copy link
Copy Markdown
Collaborator

@bigfishdesign13 bigfishdesign13 commented Feb 27, 2026

Fixes JIRA ticket ISW-5431

This PR does the following:

  • Fixed the double application of styles when a custom svg is passed into the Icon component.

How has this been tested?

  • Local Storybook and unit tests

Accessibility concerns or updates

  • n/a

Accessibility Checklist

  • Checked Storybook's "Accessibility" tab for color contrast and other issues.
  • The feature works with keyboard inputs including tabbing back and forward and pressing space, enter, arrow, and esc keys.
  • For hidden text or when aria-live is used, a screenreader was used to verify the text is read.
  • For features that involve UI updates and focusing on DOM refs, focus management was reviewed.
  • The feature works when the page is zoomed in to 200% and 400%.

Open Questions

Checklist:

  • I have updated the Storybook documentation and changelog accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nypl-design-system Ready Ready Preview, Comment Mar 3, 2026 6:36pm

Request Review

Copy link
Copy Markdown
Collaborator

@jackiequach jackiequach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I appreciate the quick turnaround 😄

summary="Renders commonly used icons in SVG format"
versionAdded="0.0.4"
versionLatest="4.1.1"
versionLatest="Prelrelease"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: minor typo

Copy link
Copy Markdown
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update looks good in storybook.

@bigfishdesign13 bigfishdesign13 added Ship it Pull requests that have been reviewed and approved. and removed Needs review Pull requests that are ready for peer review. labels Mar 3, 2026
@bigfishdesign13 bigfishdesign13 merged commit 6a8ca98 into development Mar 3, 2026
7 of 8 checks passed
@bigfishdesign13 bigfishdesign13 deleted the ISW-5431/icon-styles-bug branch March 3, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ship it Pull requests that have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants