ISW-5445: RTL styles for Select arrow#1959
Merged
bigfishdesign13 merged 2 commits intodevelopmentfrom Mar 5, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bigfishdesign13
requested review from
EdwinGuzman,
milliesavalia and
oliviawongnyc
bigfishdesign13
added
the
Needs review
oliviawongnyc
approved these changes
Mar 4, 2026
Collaborator
oliviawongnyc
left a comment
oliviawongnyc
left a comment
There was a problem hiding this comment.
Looks good to me! Annoying about the bug? And nice work figuring it out.
FYI, I tested this by updating the design system version in the turbine repo to "@nypl/design-system-react-components": "https://github.com/NYPL/nypl-design-system.git#ISW-5445/select-arrow-rtl",, then installing and testing locally.
bigfishdesign13
added
Ship it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JIRA ticket ISW-5445
This PR does the following:
Selectcomponent.How has this been tested?
NOTE: Final testing should be done in Turbine with a release candidate. In Storybook, testing was completed by manually adding
dir="rtl"to the<body>tag.Accessibility concerns or updates
Accessibility Checklist
aria-liveis used, a screenreader was used to verify the text is read.refs, focus management was reviewed.Open Questions
Checklist:
Front End Review: