SWIS-333: Update account page to be language agnostic
#571
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| import { Page, Locator } from "@playwright/test"; | ||
| import { apiTranslations } from "../../src/data/apiMessageTranslations"; | ||
| import { apiErrorTranslations } from "../../src/data/apiErrorMessageTranslations"; | ||
|
|
||
| export class AccountPage { | ||
| readonly page: Page; | ||
|
|
@@ -29,78 +30,121 @@ export class AccountPage { | |
| readonly nextButton: Locator; | ||
| readonly previousButton: Locator; | ||
|
|
||
| constructor(page: Page, appContent?: any, lang?: string) { | ||
| this.page = page; | ||
|
|
||
| const required = appContent?.required || "required"; | ||
| const withRequired = (label: string) => `${label} (${required})`; | ||
|
|
||
| this.mainHeading = page.getByRole("heading", { | ||
| name: appContent?.banner?.title || "Apply for a Library Card Online", | ||
| level: 1, | ||
| }); | ||
| this.stepHeading = page.getByRole("heading", { | ||
| name: appContent?.account?.title || "Step 4 of 5: Customize your account", | ||
| level: 2, | ||
| }); | ||
| this.usernameInput = page.getByRole("textbox", { | ||
| name: withRequired(appContent?.account?.username?.label || "Username"), | ||
| exact: true, | ||
| }); | ||
| this.usernameError = page.getByText( | ||
| appContent?.account?.errorMessage?.username || | ||
| "There was a problem. Username must be between 5-25 alphanumeric characters." | ||
| ); | ||
| this.availableUsernameButton = page.getByRole("button", { | ||
| name: | ||
| appContent?.account?.username?.checkButton || | ||
| "Check if username is available", | ||
| exact: true, | ||
| }); | ||
| this.availableUsernameMessage = page.getByText( | ||
| apiTranslations["This username is available."][lang] || | ||
| "This username is available." | ||
| ); | ||
| this.unavailableUsernameMessage = page.getByText( | ||
| apiErrorTranslations["This username is unavailable. Please try another."][ | ||
| lang | ||
| ] || "This username is unavailable. Please try another." | ||
| ); | ||
|
Comment on lines
61
to
69
Collaborator
Author
There was a problem hiding this comment. @Toxiapo simpler than I thought it would be! |
||
| this.passwordInput = page.getByRole("textbox", { | ||
| name: withRequired(appContent?.account?.password?.label || "Password"), | ||
| exact: true, | ||
| }); | ||
| this.passwordError = page.getByText( | ||
| appContent?.account?.errorMessage?.password || | ||
| "There was a problem. Your password must be at least 8 characters, include a mixture of both uppercase and lowercase letters, include a mixture of letters and numbers, and have at least one special character except period (.)" | ||
| ); | ||
| this.verifyPasswordInput = page.getByRole("textbox", { | ||
| name: withRequired( | ||
| appContent?.account?.verifyPassword?.label || "Verify password" | ||
| ), | ||
| exact: true, | ||
| }); | ||
| this.verifyPasswordError = page.getByText( | ||
| appContent?.account?.errorMessage?.verifyPassword || | ||
| "There was a problem. The two passwords don't match." | ||
| ); | ||
| this.showPasswordCheckbox = page.getByRole("checkbox", { | ||
| name: appContent?.account?.showPassword || "Show password", | ||
| }); | ||
| this.showPasswordCheckboxLabel = page.getByText( | ||
| appContent?.account?.showPassword || "Show password", | ||
| { | ||
| exact: true, | ||
| } | ||
| ); | ||
| this.homeLibraryHeading = page.getByRole("heading", { | ||
| name: appContent?.account?.library?.title || "Home library", | ||
| level: 3, | ||
| exact: true, | ||
| }); | ||
| this.nyplLocationLink = page.getByRole("link", { | ||
| name: | ||
| appContent?.account?.library?.description?.nyplLocation || | ||
| "NYPL location", | ||
| }); | ||
| this.selectHomeLibrary = page.getByLabel( | ||
| appContent?.account?.library?.selectLibrary || "Select a home library:" | ||
| ); | ||
| this.homeLibraryError = page.getByText( | ||
| appContent?.account?.errorMessage?.homeLibraryCode || | ||
| "There was a problem. Please select a home library." | ||
| ); | ||
| this.cardholderTerms = page.getByRole("link", { | ||
| name: | ||
| appContent?.account?.termsAndCondition?.termsConditions || | ||
| "Cardholder Terms and Conditions", | ||
| }); | ||
| this.rulesRegulations = page.getByRole("link", { | ||
| name: | ||
| appContent?.account?.termsAndCondition?.rulesRegulations || | ||
| "Rules and Regulations", | ||
| }); | ||
| this.privacyPolicy = page.locator("#mainContent").getByRole("link", { | ||
| name: | ||
| appContent?.account?.termsAndCondition?.privacyPolicy || | ||
| "Privacy Policy", | ||
| }); | ||
| this.acceptTermsCheckbox = page.getByRole("checkbox", { | ||
| name: | ||
| appContent?.account?.termsAndCondition?.label || | ||
| "Yes, I accept the terms and conditions.", | ||
| }); | ||
| this.acceptTermsCheckboxLabel = page.getByText( | ||
| appContent?.account?.termsAndCondition?.label || | ||
| "Yes, I accept the terms and conditions." | ||
| ); | ||
| this.acceptTermsError = page.getByText( | ||
| appContent?.account?.errorMessage?.acceptTerms || | ||
| "There was a problem. The Terms and Conditions must be checked." | ||
| ); | ||
| this.nextButton = page.getByRole("button", { | ||
| name: appContent?.button?.next || "Next", | ||
| exact: true, | ||
| }); | ||
| this.previousButton = page.getByRole("link", { | ||
| name: appContent?.button?.previous || "Previous", | ||
| exact: true, | ||
| }); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!