SWIS-347: Update congrats page to be language agnostic#589
Draft
clarissarichard wants to merge 5 commits intoSWIS-345/language-agnostic-reviewfrom
Draft
SWIS-347: Update congrats page to be language agnostic#589clarissarichard wants to merge 5 commits intoSWIS-345/language-agnostic-reviewfrom
congrats page to be language agnostic#589clarissarichard wants to merge 5 commits intoSWIS-345/language-agnostic-reviewfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
clarissarichard
changed the base branch from
main
to
SWIS-345/language-agnostic-review
clarissarichard
commented
Mar 17, 2026
Comment on lines
+164
to
+165
| "part3": "<b>{{temporaryCard}}</b> If you live, work, attend school, or pay property taxes in New York State, <a href='https://www.nypl.org/help/library-card/terms-conditions#renew'>{{learnMore}}</a> about how to update your card. If you're a researcher planning an upcoming visit more than 30 days from now, and for all other questions, contact <a href='mailto:gethelp@nypl.org'>{{getHelp}}</a>.", | ||
| "temporaryCard": "This is a temporary card and will expire in 30 days.", |
Collaborator
Author
There was a problem hiding this comment.
Note to self: Potentially update this depending on decision made for alternate-address page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
Noting that all commented tests will be resolved by the end before anything is merged to
main! This will be a bit of a tedious thing to review - apologies in advance 😅I'm going merge each PR incrementally into
SWIS-300/language-agnostic-landingand merge that PR intomain. Please let me know if y'all happen to know a better way to do this!Description
congratspage to refer to translation keyscongratspage and e2e tests to loop through languagesTickets:
Motivation and Context
Updates Playwright tests to be language agnostic.
How Has This Been Tested?
Run
npm run playwrightChecklist: