Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
roseb89
requested review from
Toxiapo,
clarissarichard,
milliesavalia and
russellcullen
and removed request for
Toxiapo
Toxiapo
requested changes
Apr 1, 2026
Collaborator
Toxiapo
left a comment
Toxiapo
left a comment
There was a problem hiding this comment.
looks great, just that one small change.
| await expect(page).toHaveURL(/.*\/review\?.*newCard=true/); | ||
| const accessibilityScanResults = await new AxeBuilder({ page }) | ||
| .withTags(["wcag21aa", "wcag22aa"]) | ||
| .analyze(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| .analyze(); | |
| .analyze(); | |
| validateA11yCoverage(accessibilityScanResults); |
| const reviewPage = new ReviewPage(page); | ||
|
|
||
| await test.step("it should tab through on Personal section", async () => { | ||
| await reviewPage.stepHeading.focus(); |
Collaborator
There was a problem hiding this comment.
I think the step heading would already be focused, so we can remove the focus() and keep the toBeFocused() assertions.
| await page.keyboard.press("Tab"); | ||
| await expect(field).toBeFocused(); | ||
| } | ||
| await reviewPage.acceptTermsCheckbox.focus(); |
Collaborator
There was a problem hiding this comment.
If we end the for loop on the checkbox, we may not need this extra focus()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Axe-core scan to Review page
Added tab navigation test
Tickets:
Motivation and Context
How Has This Been Tested?
npx playwright test review-a11y.spec.ts
Checklist: