Skip to content

Remove custom CSS, JS links #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nezlobnaya wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove custom CSS, JS links #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions custom/00_common/js/03-inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,6 @@ function injectCDNResourceTags() {
}

function injectScriptTagForCDNCustomJS() {
// We have decided to rename CDN custom.{css,js} files to external.{css,js}.
// We may not be able to deploy the package and CDN code simultaneously, so
// we are setting up a transition phase where we inject script tags for
// both custom.js and external.js. After the CDN has been updated with
// new filenames, we will delete the custom.js <script> tag.s
const scriptCustom = document.createElement( 'script' );
scriptCustom.setAttribute( 'src', `${ cdnUrl }/js/custom.js` );
document.body.appendChild( scriptCustom )

const scriptExternal = document.createElement( 'script' );
scriptExternal.setAttribute( 'src', `${ cdnUrl }/js/external.js` );
document.body.appendChild( scriptExternal );
Expand All @@ -28,12 +19,6 @@ function injectScriptTagForCDNCustomJS() {
function injectLinkTagsForCDNCustomCSS() {
[
'app-colors.css',
// We have decided to rename CDN custom.{css,js} files to external.{css,js}.
// We may not be able to deploy the package and CDN code simultaneously, so
// we are setting up a transition phase where we inject link tags for
// both custom.css and external.css. After the CDN has been updated with
// new filenames, we will delete the custom.css <link> tag.
'custom.css',
'external.css',
].forEach( file => {
const link = document.createElement( 'link' );
Expand Down