Implement zero-copy writes for the multiplexer#395
Draft
bdraco wants to merge 9 commits intoNabuCasa:mainfrom
Draft
Implement zero-copy writes for the multiplexer#395bdraco wants to merge 9 commits intoNabuCasa:mainfrom
bdraco wants to merge 9 commits intoNabuCasa:mainfrom
Conversation
Collaborator
Author
bdraco
commented
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #394
Note that this likely won't make any difference until #369 and #344 because the current implementation forces many small reads which negate much of the benefit here. Since we benchmark both sides of the connection, the benchmark won't improve much either until we can get the read buffer size a bit more aligned with the use case.
On 1 MiB message this will make quite a bit of a difference for a write op even if its only a small part of the whole stack:
