fix: Voiceチャンネルに入った状態でそのチャンネルのTextチャットを使うと!vrcが動かないバグの修正#3
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the !vrc command would fail when invoked from a text channel attached to a voice channel. The issue occurred because Discord uses the same ID for both the voice channel and its attached text channel, causing lock conflicts with the single channel_semaphore.
Key Changes:
- Split
channel_semaphoreinto separatetext_channel_semaphoreandvoice_channel_semaphoreinstances - Updated both
rcandvrccommands to use the appropriate semaphore(s)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VoiceチャンネルのIDとVoiceチャンネルについているTextチャンネルのIDが同じであり、間違ってロックが発生していた