Refactor main.py: use setup_hook pattern and reorder event handlers#5
Merged
Nanahuse merged 3 commits intorefactor/remove_global_variablefrom Dec 1, 2025
Merged
Conversation
…_hook pattern Co-authored-by: Nanahuse <109294061+Nanahuse@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on refactoring to introduce commands.Cog
Refactor main.py: use setup_hook pattern and reorder event handlers
Dec 1, 2025
Nanahuse
requested changes
Dec 1, 2025
src/main.py
Outdated
| async def setup_hook() -> None: | ||
| await bot.add_cog(CountdownCog(logger, load_env.load_countdown_source())) | ||
|
|
||
| bot.setup_hook = setup_hook |
Owner
There was a problem hiding this comment.
この行に # type: ignore[assignment]を追加して
Co-authored-by: Nanahuse <109294061+Nanahuse@users.noreply.github.com>
Nanahuse
approved these changes
Dec 1, 2025
Nanahuse
added a commit
that referenced
this pull request
Dec 1, 2025
* refactor * Refactor main.py: use setup_hook pattern and reorder event handlers (#5) --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_readyevent handler definition to follow Discord bot patternson_readybefore cog registration and usesetup_hookfor cog loading# type: ignore[assignment]to setup_hook assignment per reviewer requestSecurity Summary: No security vulnerabilities found.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.