fix: Fix not being able to see some templates#5705
Open
marcindobry wants to merge 1 commit intomasterfrom
Open
fix: Fix not being able to see some templates#5705marcindobry wants to merge 1 commit intomasterfrom
marcindobry wants to merge 1 commit intomasterfrom
Conversation
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
marcindobry
force-pushed
the
marcin/NAN-5120/fix-not-being-able-to-see-templates
branch
from
faeb5a4 to
ae2e919
Compare
TBonnin
approved these changes
Mar 25, 2026
kaposke
reviewed
Mar 25, 2026
| expect(scriptListFile).not.toBeUndefined(); | ||
| }); | ||
|
|
||
| it('should keep renamed templates visible when an older sync with different endpoint exists', async () => { |
Contributor
There was a problem hiding this comment.
Isn't it supposed to be "when an older sync with the same model name exists"? (And same reflected on the test)
marcindobry
force-pushed
the
marcin/NAN-5120/fix-not-being-able-to-see-templates
branch
2 times, most recently
from
d6dace1 to
737e18b
Compare
marcindobry
force-pushed
the
marcin/NAN-5120/fix-not-being-able-to-see-templates
branch
from
737e18b to
fd848ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robin noticed that when he had a
hubspot/userssync previously deployed (and disabled now), the newhubspot/sync-userstemplate wasn't even available to turn on. This was the case for a few other syncs too.The reason for that is we are filtering templates that sync models with the same name as any other previously deployed sync. Since syncs can't influence models from other syncs, this doesn't seem to make sense.
This PR updates flow template deduplication so templates are no longer filtered out solely due to sharing model names with previously deployed syncs, and adds an integration test to ensure renamed templates remain visible when legacy syncs exist.
This summary was automatically generated by @propel-code-bot