Conversation
Run a locked hourly cron to: - report enabled growth add-ons on plans that do not support them; - activate due add-ons for eligible plans; - terminate add-ons whose end date has passed. Also adds `growth_features_starts_at` to `plans` in order to unlock the enabling of growth add-ons on a schedule.
Contributor
Preview Deploys
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found and verified against the latest diff
Confidence score: 4/5
packages/database/lib/migrations/20260911120000_plans_add_growth_addon_start.cjslacks an index for the hourlygrowth_features_starts_at <= snapshotpredicate, which could cause each run to scan every plan row and degrade database performance as data grows — add a partial index for this filter.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/database/lib/migrations/20260911120000_plans_add_growth_addon_start.cjs">
<violation number="1" location="packages/database/lib/migrations/20260911120000_plans_add_growth_addon_start.cjs:5">
P2: The hourly growth-addon update filters on `growth_features_starts_at <= snapshot`, but this migration creates no index for that predicate. Add a partial index so each hourly run does not scan every plan row as the plans table grows.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| * @param {import('knex').Knex} knex | ||
| */ | ||
| exports.up = async function (knex) { | ||
| await knex.raw(`ALTER TABLE plans ADD COLUMN IF NOT EXISTS growth_features_starts_at timestamptz`); |
Contributor
There was a problem hiding this comment.
P2: The hourly growth-addon update filters on growth_features_starts_at <= snapshot, but this migration creates no index for that predicate. Add a partial index so each hourly run does not scan every plan row as the plans table grows.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/database/lib/migrations/20260911120000_plans_add_growth_addon_start.cjs, line 5:
<comment>The hourly growth-addon update filters on `growth_features_starts_at <= snapshot`, but this migration creates no index for that predicate. Add a partial index so each hourly run does not scan every plan row as the plans table grows.</comment>
<file context>
@@ -0,0 +1,11 @@
+ * @param {import('knex').Knex} knex
+ */
+exports.up = async function (knex) {
+ await knex.raw(`ALTER TABLE plans ADD COLUMN IF NOT EXISTS growth_features_starts_at timestamptz`);
+};
+
</file context>
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run a locked hourly cron to:
Also adds
growth_features_starts_attoplansin order to unlock the enabling of growth add-ons on a schedule.