Updated coefficients and variables - Small file structure changes#76
Merged
yamilbknsu merged 4 commits intodevfrom Sep 22, 2025
Merged
Updated coefficients and variables - Small file structure changes#76yamilbknsu merged 4 commits intodevfrom
yamilbknsu merged 4 commits intodevfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the coefficients and model expressions for various logit models to improve their accuracy and adds new demographic variables for better model fitting. It also finalizes documentation and file structure for v1.0.0 release.
- Updates model coefficients and expressions across multiple demographic models (mortality, marriage, education, etc.)
- Adds new age bin and family size variables for enhanced model precision
- Implements proper handling of geographic identifiers (geoid vs county assignment)
- Creates configuration file for SF Bay Area example
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| notebooks/DevTODO.md | Updates task completion status for model coefficients |
| demos/variables.py | Adds new age bin and marital status variables for updated models |
| demos/models/kids_moving.py | Separates geoid and county assignment for proper geographic handling |
| demos/models/household_reorg.py | Implements separate geoid and county assignment logic |
| demos/config.py | Adds validation for required lcm_county_id column |
| data/sf_bay_example/calibrated_models_coefficients/*.yaml | Updates model coefficients and expressions across all demographic models |
| configuration/demos_config_sfbay.toml | Creates comprehensive configuration for SF Bay Area example |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the coefficients of the logit models and finalizes documentation and file structure for v1.0.0.
It also closes issue #75