Skip to content

TOD factors for cmod_single_owner_heat#2024

Merged
sjanzou merged 10 commits intodevelopfrom
iph-dispatch
Mar 9, 2025
Merged

TOD factors for cmod_single_owner_heat#2024
sjanzou merged 10 commits intodevelopfrom
iph-dispatch

Conversation

@sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Mar 5, 2025

Pull Request Template

Description

TOD factors implemented for IPH models in cmod_single_owner

[ include directions for reviewers if necessary- what or how should they test or review ]

Corresponding branches and PRs:

Goes with ssc NatLabRockies/ssc#1290

Checklist

  • [ x] requires help revision and I added that label
  • [ x] adds, removes, modifies, or deletes variables in existing compute modules
  • [x ] changes defaults
  • [ x] I've tagged this PR to a milestone

Questions

  1. TOD output labels “Energy” to “Thermal energy” and “Power” to “Thermal power” and units from “kWh” to “kWht” based on other output updates - is that correct?
  2. Suspect outputs - are we going through in detail in this pull request?
    image

tyneises and others added 5 commits February 18, 2025 15:21
clean up dispatch and tod logic on mspt iph forms
clean up dispatch and tod logic on trough iph forms
clean up dispatch and tod logic on fresnel iph forms
@sjanzou sjanzou self-assigned this Mar 5, 2025
@sjanzou sjanzou added this to the 2024 Release Patch 1 milestone Mar 5, 2025
@brtietz brtietz changed the base branch from patch to develop March 5, 2025 21:21
@cpaulgilman cpaulgilman added the requires help revision Requires a Help revision before releasing public version label Mar 6, 2025
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing BTM outputs for the IPH Tower Molten Salt / Single Owner configuration that I don't think belong:

image

@cpaulgilman
Copy link
Collaborator

cpaulgilman commented Mar 6, 2025

@taylorbrown75, @tyneises Do we want to add a Copy schedule from TOD Factors page button like is available for CSP configurations?

image

image

@tyneises
Copy link
Collaborator

tyneises commented Mar 6, 2025

@taylorbrown75, @tyneises Do we want to add a Copy schedule from TOD Factors page button like is available for CSP configurations?

image

image

Thanks, Paul, I added it

@sjanzou
Copy link
Collaborator Author

sjanzou commented Mar 6, 2025

I'm seeing BTM outputs for the IPH Tower Molten Salt / Single Owner configuration that I don't think belong:

image

@tyneises , @cpaulgilman - just checking that the electricity bill and expenses are what we want and we want to eliminate any exports - correct?

@sjanzou
Copy link
Collaborator Author

sjanzou commented Mar 7, 2025

I'm seeing BTM outputs for the IPH Tower Molten Salt / Single Owner configuration that I don't think belong:

image

@cpaulgilman, the BTM outputs (e.g. exports, bill with system, etc.) are not specific to the IPH/SO models. Whenever the "Use retail electricity rate(s)" option on the Electricity Purchases page for all the FOM configurations:
image

the outputs you mentioned appear in the data tables (e.g. PVWatts/SO):
image

Should we make a separate issue for all FOM configurations that use retail rates or address for cmod_singleowner_heat in this pull request? The issue is most notable for the IPH models since the "Use PPA or market prices" Electricity Purchases option is not available (e.g. MSPT IPH/SO):
image

Sample project file attached here
iph-dispatch.zip

@sjanzou sjanzou requested a review from cpaulgilman March 7, 2025 09:52
@cpaulgilman
Copy link
Collaborator

Should we make a separate issue for all FOM configurations that use retail rates or address for cmod_singleowner_heat in this pull request? The issue is most notable for the IPH models since the "Use PPA or market prices" Electricity Purchases option is not available (e.g. MSPT IPH/SO)

I agree with making a separate issue for FOM to suppress electricity bill outputs when retail rates are not used, and also to not show outputs like "without system" and "bill savings" that don't apply. See #2030

(When I was reviewing earlier, I didn't notice the Electricity Purchases page because I'm used to seeing it at the bottom of the input buttons for other configurations. My mistake.)

@janinefreeman janinefreeman removed this from the 2024 Release Patch 1 milestone Mar 7, 2025
@sjanzou sjanzou merged commit 8b459dc into develop Mar 9, 2025
8 checks passed
@sjanzou sjanzou deleted the iph-dispatch branch March 9, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires help revision Requires a Help revision before releasing public version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants