Skip to content

Rjf/expected maxspeed#105

Merged
robfitzgerald merged 2 commits intomainfrom
rjf/expected-maxspeed
Feb 13, 2026
Merged

Rjf/expected maxspeed#105
robfitzgerald merged 2 commits intomainfrom
rjf/expected-maxspeed

Conversation

@robfitzgerald
Copy link
Collaborator

Closes #104 by handling the supposed degenerate case where a record has a min speed but no posted max speed. when collecting speed values we now confirm that max_speed is not None.

@robfitzgerald
Copy link
Collaborator Author

@yamilbknsu this comes from an error on my continental run:

[2026-02-11T21:07:32Z INFO  bambam_omf::collection::collector] Collecting OvertureMaps Connector records from release 2026-01-21.0
[2026-02-11T21:07:32Z INFO  bambam_omf::collection::collector] Started collection
[2026-02-11T21:08:07Z INFO  bambam_omf::collection::collector] Collection time 34.542277059s
[2026-02-11T21:09:10Z INFO  bambam_omf::collection::collector] Deserialization time 63.490600362s
[2026-02-11T21:09:10Z INFO  bambam_omf::collection::collector] Total time 98.032924713s
[2026-02-11T21:09:16Z INFO  bambam_omf::collection::collector] Collecting OvertureMaps Segment records from release 2026-01-21.0
[2026-02-11T21:09:16Z INFO  bambam_omf::collection::collector] Started collection
[2026-02-11T21:12:07Z INFO  bambam_omf::collection::collector] Collection time 170.186251831s
[2026-02-11T21:13:16Z INFO  bambam_omf::collection::collector] Deserialization time 69.177046809s
[2026-02-11T21:13:16Z INFO  bambam_omf::collection::collector] Total time 239.363331088s
locating missing connectors: 209696533it [01:59, 1748865.00it/s]
[2026-02-11T21:17:33Z INFO  bambam_omf::graph::serialize_ops] all connectors accounted for
Error: InternalError("Expected a value for `max_speed`: SegmentSpeedLimit { min_speed: Some(SpeedLimitWithUnit { value: 35, unit: Mph }), max_speed: None, is_max_speed_variable: None, when: Some(SegmentAccessRestrictionWhen { during: None, heading: Some(Backward), using: None, recognized: None, mode: None, vehicle: None }), between: Some([0.0, 0.418244116]) }")
srun: error: x1004c0s7b1n0: task 0: Exited with exit code 1

Copy link
Collaborator

@yamilbknsu yamilbknsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Thank you!

@robfitzgerald robfitzgerald merged commit 01ec845 into main Feb 13, 2026
1 check passed
@robfitzgerald robfitzgerald deleted the rjf/expected-maxspeed branch February 13, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expected a value for max_speed

2 participants